feat: rework useTransition #750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleclarson
force-pushed
the
useTransition-1
branch
3 times, most recently
from
2aa8fca to
e84e95c
Compare
aleclarson
force-pushed
the
useTransition-1
branch
from
e84e95c to
52e2a82
Compare
This comment has been minimized.
This comment has been minimized.
aleclarson
added a commit
to pmndrs/react-spring-examples
that referenced
this pull request
Jul 10, 2019
Sister PR to pmndrs/react-spring#750
5 tasks
aleclarson
force-pushed
the
useTransition-1
branch
2 times, most recently
from
2143753 to
4533b50
Compare
aleclarson
force-pushed
the
useTransition-1
branch
from
e89faed to
6c24856
Compare
Babel doesn't support them currently
This lets users pass immutable objects as items
For guaranteed DOM order
because it minifies better
This lets us avoid ternary operators more
and remove "transition.id" in favor of "transition.spring.id"
aleclarson
force-pushed
the
useTransition-1
branch
from
6c24856 to
09d26b1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed in favor of #809