fix: ensure "AnimatedString#setValue" sets "node.lastPosition" and re…

…turns a boolean Fixes #642 (comment)
pmndrs · May 3, 2020 · 9010fd0 · 9010fd0
1 parent b6e7110
commit 9010fd0
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/packages/animated/src/AnimatedString.ts b/packages/animated/src/AnimatedString.ts
@@ -26,8 +26,15 @@ export class AnimatedString extends AnimatedValue<Value> {
   }
 
   setValue(value: Value) {
-    this._string = is.num(value) ? null : value
-    this._value = is.num(value) ? value : 1
+    if (!is.num(value)) {
+      this._string = value
+      this._value = 1
+    } else if (super.setValue(value)) {
+      this._string = null
+    } else {
+      return false
+    }
+    return true
   }
 
   reset(isActive?: boolean, goal?: string) {