Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: patch vite to work with preconstruct dev #129

Merged
merged 4 commits into from
Mar 10, 2021

Conversation

dbismut
Copy link
Collaborator

@dbismut dbismut commented Mar 9, 2021

While waiting for vitejs/vite#2405 to be fixed, patch Vite with temp fix explained here preconstruct/preconstruct#378 (comment)

This should allow Vite demo to work without preconstruct watch!

@vercel
Copy link

vercel bot commented Mar 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/leva/35ZQrU1GyBi2sKoc2o5RgH6yQefr
✅ Preview: https://leva-git-chore-preconstruct-patch-vite-pmndrs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 9, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 29928b1:

Sandbox Source
leva-minimal Configuration
leva-busy Configuration
leva-scroll Configuration
leva-plugin-spring Configuration
leva-advanced-panels Configuration
leva-ui Configuration
leva-theme Configuration
leva-custom-plugin Configuration

@gsimone
Copy link
Member

gsimone commented Mar 10, 2021

Is that all that's required from vite to make it work? Should we also PR this?

@dbismut
Copy link
Collaborator Author

dbismut commented Mar 10, 2021

I wouldn't know. From the comment I linked the author says it's a bit naive. In our case it works but I wouldn't make a PR without having a complete knowledge of Vite's internals.

@dbismut dbismut merged commit fec93e2 into master Mar 10, 2021
@dbismut dbismut deleted the chore/preconstruct-patch-vite branch March 18, 2021 16:47
@cwlsn
Copy link

cwlsn commented Jun 23, 2021

Just went down this rabbit hole for about a week and using your patch-package strategy worked, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants