fix: number units can be symbols such as % (#350)

pmndrs · Jun 27, 2022 · 61f88f7 · 61f88f7 · vercel · Jun 27, 2022
1 parent c0cce67
commit 61f88f7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/.changeset/wild-pants-reflect.md b/.changeset/wild-pants-reflect.md
@@ -0,0 +1,5 @@
+---
+'leva': patch
+---
+
+[number]: unit can be symbols such as '%' (#349)
diff --git a/packages/leva/src/components/Number/number-plugin.ts b/packages/leva/src/components/Number/number-plugin.ts
@@ -18,12 +18,9 @@ export const format = (v: any, { pad = 0, suffix }: InternalNumberSettings) => {
 export const normalize = ({ value, ...settings }: NumberInput) => {
   const { min = -Infinity, max = Infinity, ..._settings } = settings
 
-  const _value = clamp(parseFloat(value as string), min, max)
-  let suffix
-  if (!Number.isFinite(value)) {
-    const match = String(value).match(/[A-Z]+/i)
-    if (match) suffix = match[0]
-  }
+  let _value = parseFloat(value as string)
+  const suffix = typeof value === 'string' ? value.substring(('' + _value).length) : undefined
+  _value = clamp(_value, min, max)
 
   // ideally:
   // 3 -> 3.0