-
-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snapshot-based devtools (1st iteration) #425
Conversation
Everyone feel free to take a look. @dai-shi with this current logic in
How do I create tests for the devtools stuff? I could find a simple solution with CC: @Thiesl137 |
Great work. So far, so good. I'd like to spend time to think about better internal apis for second iteration.
This is something we are not happy with. I just added to pass some of tests (optimizations?), but happy to remove it and handle it in tests, if there's a solution (there must be). |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pmndrs/jotai/8o7y3NHyh7cEU2HbHAKQ4dQHbCwx [Deployment for 6cc8f88 failed] |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b0e9b07:
|
Add tests
@dai-shi Feel free to review now. Make sure to look at imports aswell, not sure how to deal with those without exposing a bunch of internal APIs. I think we should let me be undocumented, while we iterate on this API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks good to me for the 1st iteration.
#446 is merged. Please adjust this PR a bit. |
See #388.
This is the first iteration of snapshot-based devtools. It's not ready yet for public use.