Store immutable tags internally as plain values #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this improves performance of decode & compare since there's less levels of indirection and also no need to allocate useless objects. since we generally use the CompoundTag special-type methods anyway it means we can avoid a lot of object creations if the expected type is only one type. Memory usage should also benefit, but I haven't had a chance to do detailed profiling yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #126.
The memory usage improvement is very slim according to initial tests - sadly the gains from not allocating the simple tag objects are negated by the losses from having a separate
valueTypesarray inCompoundTag.Write performance is also marginally worse because of the extra array lookup in
CompoundTag->valueTypes.However, the performance of decoding is improved by about 10%, and equals() is more than 2x faster.
This architecture would favour implementing NBT as a PHP extension, since we'd be able to do considerably more optimizations at the native level than we can here.