Drop loader-utils dep #865
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of require("loader-utils").getOptions(LoaderContext) we should
be good with LoaderContext.getOptions(), where LoaderContext is bound to
this.
This lets us drop the loader-utils dep, which until 3.2.1 contains a
ReDoS vulnerability (CVE-2022-37603).
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
require("loader-utils").getOptions(LoaderContext)we should be good withLoaderContext.getOptions(), whereLoaderContextis bound tothis.This lets us drop the
loader-utilsdep, which until 3.2.1 contains a ReDoS vulnerability (CVE-2022-37603).Note since it is still a transitive dependency (via
webpack-v4andbabel-loader), it will still be necessary to add a resolution for it.