-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: error integration #3
Conversation
# Conflicts: # src/helpers/injectRefreshEntry.js
# Conflicts: # yarn.lock
# Conflicts: # src/runtime/globals.js
Implemented this idea as the default option with an escape hatch to disable the check just in case the user is doing something exotic. Moving on to tweaking the layout of the overlay. |
Getting |
Fixed. I broke something after stashing, sorry. |
Is it worth keeping it in a branch / unreleased at this point? Might be easier to test outside of this repo. |
Maybe I'll merge this first, then release it under my scope so that the world can test it? |
Sure |
Did some last minute bug fixes and remodeled some parts of the overlay. Time to merge this to release |
After a few nights of hard work this is finally presentable 🎉
There are still a lot of things that are missing here: no custom error overlays, no ways to disable the integration, no support for proxies, etc. Those will come later - I think it is more important for us to get the general DX right.
Please feel free to use this PR to track/iterate on changes that have to be made.
(Side note: I am debating to split the error overlay into a separate package/refactor with React, but didn't want to add build steps and mono-repo infra to this tiny plugin repo just yet)
@bvaughn @gaearon
Please test out the branch and comment on the DX 🙇
CC @charrondev @maisano - Since you two have adopted the concept early. I would be happy if you can try this out in real projects too.