fix: make sure injected imports will be processed by whatever comes next #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix ensures injected dependencies via loaders will get picked up and wrapped/processed by whatever transform is coming next (Babel/TS/etc). This is important in some scenarios (e.g. dependency-related helpers with caching behaviour) and will help maintain referential equality across hot updates for the "family" reference generated by
react-refresh/runtime. This also makes sure when dependencies are being mangled/wrapped in other loaders, our injected ones will be processed too, so it ensures that only on version of a dependency can be used.Fixes #120