Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in pip editable install mode #486

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

jhabriel
Copy link
Contributor

I'm not entirely sure what's causing the error. It seems to be related either to setuptools or to poetry, or maybe both. Thus, this is more or less a brute force fix. I've found it here: python-poetry/poetry#3001

I'm not entirely sure what's causing the error. It seems to be related either to setuptools or to poetry, or maybe both. Thus, this is more or less a brute force fix. I've found the it here: python-poetry/poetry#3001
@jhabriel jhabriel added the bug-fix Something not working is fixed. label Nov 19, 2020
@keileg
Copy link
Contributor

keileg commented Nov 19, 2020

@alessiofumagalli: You can confirm that this indeed fixed the issue you encountered?

If yes, I think we will merge. I will then do an extra check of this when I get around to testing python 3.9, but that is some steps down the road.

@alessiofumagalli
Copy link
Contributor

ready to merge for me, thanks @jhabriel

@keileg keileg merged commit 66c2183 into pmgbergen:develop Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Something not working is fixed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants