Skip to content
This repository has been archived by the owner on Mar 22, 2023. It is now read-only.

docker: update pmdk installed version to 1.12.0 #1265

Open
wants to merge 1 commit into
base: stable-1.13
Choose a base branch
from

Conversation

lukaszstolarczuk
Copy link
Member

@lukaszstolarczuk lukaszstolarczuk commented Jul 22, 2022

I believe this fix is required since stable-1.13 branch


This change is Reviewable

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #1265 (8f2e068) into stable-1.13 (f49772a) will decrease coverage by 1.46%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           stable-1.13    #1265      +/-   ##
===============================================
- Coverage        95.52%   94.06%   -1.47%     
===============================================
  Files               53       52       -1     
  Lines             6755     5142    -1613     
===============================================
- Hits              6453     4837    -1616     
- Misses             302      305       +3     
Flag Coverage Δ
tests_clang_debug_cpp17 93.63% <ø> (-1.48%) ⬇️
tests_gcc_debug 90.75% <ø> (-1.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/libpmemobj++/mutex.hpp 86.20% <0.00%> (-10.57%) ⬇️
include/libpmemobj++/make_persistent_array.hpp 72.88% <0.00%> (-10.02%) ⬇️
include/libpmemobj++/shared_mutex.hpp 80.00% <0.00%> (-8.89%) ⬇️
include/libpmemobj++/timed_mutex.hpp 80.64% <0.00%> (-8.83%) ⬇️
include/libpmemobj++/allocator.hpp 71.05% <0.00%> (-8.20%) ⬇️
include/libpmemobj++/pexceptions.hpp 44.61% <0.00%> (-5.39%) ⬇️
include/libpmemobj++/make_persistent.hpp 68.42% <0.00%> (-4.92%) ⬇️
include/libpmemobj++/detail/common.hpp 90.00% <0.00%> (-4.60%) ⬇️
...memobj++/experimental/atomic_self_relative_ptr.hpp 84.28% <0.00%> (-3.79%) ⬇️
include/libpmemobj++/pext.hpp 95.65% <0.00%> (-3.22%) ⬇️
... and 28 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@karczex karczex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved

@lukaszstolarczuk lukaszstolarczuk added this to the 1.9 milestone Jul 25, 2022
Copy link

@Karolina002 Karolina002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)

@lukaszstolarczuk lukaszstolarczuk marked this pull request as draft July 26, 2022 09:50
@lukaszstolarczuk lukaszstolarczuk changed the base branch from stable-1.9 to stable-1.11 July 26, 2022 10:47
@lukaszstolarczuk
Copy link
Member Author

We'll merge this to the appropriate stable branch, whenever it'll be required. As @karczex stated, this is likely not needed on stable-1.9.

@lukaszstolarczuk lukaszstolarczuk modified the milestones: 1.9, 1.13 Aug 23, 2022
@lukaszstolarczuk lukaszstolarczuk changed the base branch from stable-1.11 to stable-1.13 August 23, 2022 10:57
@lukaszstolarczuk
Copy link
Member Author

I've updated the PR to target the stable-1.13 branch

@lukaszstolarczuk
Copy link
Member Author

need to bump to 1.12.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants