Skip to content

Set default ClientId and GroupId #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025
Merged

Set default ClientId and GroupId #75

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4ce6c4
Set default ClientId and GroupId
pmdevers May 19, 2025
9ceb5a2
Update test/MinimalKafka.Tests/RegistrationTests.cs
pmdevers May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/MinimalKafka/KafkaExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
using MinimalKafka.Extension;
using MinimalKafka.Serializers;
using MinimalKafka.Stream;
using System.Reflection;
using System.Text.Json;

namespace MinimalKafka;
Expand Down Expand Up @@ -47,6 +48,8 @@ public static IServiceCollection AddMinimalKafka(this IServiceCollection service
var conventions = new List<Action<IKafkaBuilder>>();
var configBuilder = new AddKafkaBuilder(services, conventions);

configBuilder.WithClientId(AppDomain.CurrentDomain.FriendlyName);
configBuilder.WithGroupId(AppDomain.CurrentDomain.FriendlyName);
configBuilder.WithKeyDeserializer(typeof(JsonTextSerializer<>));
configBuilder.WithValueDeserializer(typeof(JsonTextSerializer<>));
configBuilder.WithTopicFormatter(topic => topic);
Expand Down
22 changes: 22 additions & 0 deletions test/MinimalKafka.Tests/RegistrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Hosting;
using MinimalKafka.Builders;
using MinimalKafka.Metadata;
using MinimalKafka.Serializers;
using MinimalKafka.Stream;
using System.Diagnostics;
Expand Down Expand Up @@ -97,4 +98,25 @@ static void config(IAddKafkaBuilder builder) =>
// Assert
kafkaBuilder.Should().NotBeNull();
}

[Fact]
public void AddMinimalKafa_Should_Set_ClientId_And_GroupId_To_Default()
{
var services = new ServiceCollection();

static void config(IAddKafkaBuilder builder) =>
builder.WithStreamStore(typeof(InMemoryStore<,>));

// Act
services.AddMinimalKafka(config);
var serviceProvider = services.BuildServiceProvider();
var kafkaBuilder = serviceProvider.GetRequiredService<IKafkaBuilder>();

// Assert
kafkaBuilder.MetaData
.Should()
.ContainSingle(x => x is IClientIdMetadata)
.And
.ContainSingle(x => x is IGroupIdMetadata);
}
}