Skip to content

Conversation

@dtsosie
Copy link

@dtsosie dtsosie commented Feb 21, 2015

Enhancement to Auto-Detect to pull LDAP Base and Connection using Open Directory Connection Detection

Obtains the connection source node for the User the SMBLastPWD is being drawn from. Then reads connection and ldap base. If this fails, it will fallback to previous behavior.

Verified on OS X 10.10 binded to Active Directory foreset at Go Daddy

@pmbuko
Copy link
Owner

pmbuko commented Aug 12, 2015

Sorry for not getting to this earlier. I haven't merged it because I don't see OriginalNodeName in my dscl results.

@pmbuko pmbuko closed this Aug 12, 2015
@dtsosie
Copy link
Author

dtsosie commented Aug 12, 2015

And as designed it will fallback to your code stack. For an enterprise like
GoDaddy, our Macs are actually joined to a domain and that will actually
work. We have deployed this code on 1800 macs and it works. My job was to
make your code work for our laptops, but I did it with an eye of ensuring
backword compatibility to your code base.

There are at least 2 comments on this project that my fix will alleviate. I
strongly recommend integrating my code. I have 1800 happy testers for the
past few months. I thank you for the initial code as it made my bosses
happy, but allow my contribution to further your endeavor.

On Wed, Aug 12, 2015 at 7:47 AM, Peter Bukowinski [email protected]
wrote:

Sorry for not getting to this earlier. I haven't merged it because I don't
see OriginalNodeName in my dscl results.


Reply to this email directly or view it on GitHub
#2 (comment).

@pmbuko pmbuko reopened this Aug 12, 2015
@pmbuko
Copy link
Owner

pmbuko commented Aug 12, 2015

Ok, you've convinced me. I see that it'll fall back to my own code and that's good enough for me.

pmbuko added a commit that referenced this pull request Aug 12, 2015
Obtain AD LDAP Connection and Base from dscl
@pmbuko pmbuko merged commit 432985d into pmbuko:master Aug 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants