Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Mxalloc() detection #2

Closed
mikrosk opened this issue Apr 17, 2023 · 1 comment
Closed

Bug in Mxalloc() detection #2

mikrosk opened this issue Apr 17, 2023 · 1 comment

Comments

@mikrosk
Copy link
Collaborator

mikrosk commented Apr 17, 2023

atari_mxalloc_avail = ((Sversion()&0xFF)>=0x01) | (Sversion()>=0x1900);
contains quite a suspicious code:

  • it checks for major GEMDOS version 1.x (is there such?)
  • it uses | instead of || for the check but it works by chance because previous condition always (?) fails
pmandin added a commit that referenced this issue Aug 15, 2023
pmandin added a commit that referenced this issue Aug 15, 2023
@pmandin
Copy link
Owner

pmandin commented Aug 15, 2023

I don't know where the check for the lower byte comes from, maybe difference between MegaSTe and TT (both have 0.19) ?
I copy/pasted it from SDL, (so same problem there).

Anyway, fixed

@pmandin pmandin closed this as completed Aug 15, 2023
mikrosk added a commit to mikrosk/SDL-1.2 that referenced this issue Sep 10, 2023
See also pmandin/cleancode#2 (where it was
fixed in a different way).
mikrosk added a commit to mikrosk/SDL-1.2 that referenced this issue Nov 27, 2023
See also pmandin/cleancode#2 (where it was fixed in a different way)
mikrosk added a commit to mikrosk/SDL-1.2 that referenced this issue Dec 21, 2023
See also pmandin/cleancode#2 (where it was fixed in a different way)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants