-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bad "id" on medias select folder + install in my lang + PHP7.4 ready #349
Conversation
Found & fix for kzGallery. thanks to Bazooka07 for this plug
@@ -7,6 +7,9 @@ | |||
'L_WRONG_PHP_VERSION' => 'PluXml requesís PHP 5 o superior per foncionar.', | |||
'L_SELECT_LANG' => 'Seleccionatz vòstra lenga', | |||
'L_INPUT_CHANGE' => 'Cambiar', | |||
'L_INSTALL_DATA' => 'Installer les données exemples', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ici cela devrait être en occitan
@@ -161,7 +161,7 @@ function($item) { return !preg_match('@\.tb\.\w+$@', $item); } # On rejette les | |||
* @author Stephane F, Danielsan, J.P. "bazooka07" Pourrez | |||
**/ | |||
public function contentFolder() { | |||
plxUtils::printSelectDir('folder', $this->dir, $this->path, 'no-margin'); | |||
plxUtils::printSelectDir('folder', $this->dir, $this->path, 'no-margin', true, 'folder'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On indique Que l'on veut un id égale à folder
Deprecated: Function get_magic_quotes_gpc() is deprecated in core/lib/class.plx.utils.php on line 49
@@ -46,7 +46,7 @@ public static function unSlash($content) { | |||
|
|||
$new_content = ''; | |||
|
|||
if(get_magic_quotes_gpc() == 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deprecated php7.4
@@ -46,7 +46,7 @@ public static function unSlash($content) { | |||
|
|||
$new_content = ''; | |||
|
|||
if(get_magic_quotes_gpc() == 1) { | |||
if(ini_get('magic_quotes_gpc') == 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe
C'est tout bon pour moi. Je fais quelques tests et je merge asap. |
Après vérification, depuis la version 5.4 de PHP, la fonction "get-magic-quotes-gpc" retourne systématiquement "false" (https://www.php.net/manual/fr/function.get-magic-quotes-gpc.php), la fonctionnalité des magic quotes ayant été supprimée. On peut donc simplement retirer le test if..else et ne garder que le code où la condition est vrai (lignes 50 à 63 incluse). Est-ce que tu peux ajouter ça à la PR, stp ? |
J'ai fais la modification. Par ailleurs, l'installation ne fonctionne plus, on reste bloqué sur la page d'installation. Je n'ai pas encore analysé pourquoi. |
Corrigé par la PR : #350 |
Mergé dans PluXml 5.8 (develop). |
Found & Fix for kzGallery-1.0.0 (button "copy" not present in medias manager)
Thanks to @bazooka07 for this plug
Install (or not) sample data + lang (oc is in french)
& following lang selector after reload