Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable day headers completely. #249

Merged
merged 2 commits into from
Mar 25, 2017

Conversation

SimenCodes
Copy link
Contributor

I have the widget configured to only display my agenda for the day, and I found the date headers only take up additional space without really adding any new information. So, I added an option to remove them. This is primarily something I made for myself, but figured other people might be interested too

 When configured to only display events for the current day, the header will only add additional clutter.
@yvolk
Copy link
Collaborator

yvolk commented Mar 18, 2017

Hello @SimenCodes , thank you for the contribution.
I see these problems though that need to be fixed:

  1. Please rename in your changes all names/references etc. of "day entries" to "day headers" to avoid confusion.
  2. Tests are broken now. Please fix them. (To launch tests locally in "Android Studio" right-click on the app\calendar-widget\src\androidTest\java folder and select "Run All tests" menu item...)

or see Travis build https://travis-ci.org/plusonelabs/calendar-widget/builds/207890973#L3228 , line 3228:

Error in testBirthdayOneDayOnly:
org.json.JSONException: No value for showDayEntries
at org.json.JSONObject.get(JSONObject.java:389)

@SimenCodes
Copy link
Contributor Author

Hi @yvolk, thanks for the feedback. Have updated all references to "day headers" now, and added the missing JSON value to make the tests run again.

@yvolk
Copy link
Collaborator

yvolk commented Mar 26, 2017

@SimenCodes Please look how your feature works with the new "Single line layout" #42 (comment)

@yvolk yvolk added this to the 1.10.0 milestone Apr 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants