Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust event color opacity/disable #234

Closed

Conversation

xuvatilavv
Copy link
Contributor

Solves issue #174.

Adds Appearance preference option to change event color opacity to 100%, 50%, 0%, or Disable. Percentages affect alpha value and leaves space reserved, "Disable" sets the bar to "GONE" leaving a more condensed layout for narrow widget sizes.

Only includes English locale strings.

@mpost
Copy link
Collaborator

mpost commented Jun 27, 2016

Thanks for the contribution. I will have a closer look.

@mpost
Copy link
Collaborator

mpost commented Jul 31, 2016

A few comments... Wouldn't a slider with some more discrete values be nicer? Eg. with 10% increments. Also Could you squash your commits into one?

…ffecting color alpha and optionally disabling the color block entirely.
@xuvatilavv
Copy link
Contributor Author

Squashed the commits.

A slider would definitely be nicer and is what I originally intended, but I wasn't sure how to do it. I researched a bit and tried pulling the slider from the color picker already in the app but couldn't get it to work on its own. I've been working on some personal projects for a while so I haven't gone back to look at it yet.

@yvolk
Copy link
Collaborator

yvolk commented Oct 13, 2019

@xuvatilavv Closing as the PR is outdated now.
BTW recently we migrated to the new Color Picker that allows to change opacity as you wish in a more intuitive way.
Note: Please create new PRs in that repository:
https://github.com/andstatus/todoagenda/pulls

@yvolk yvolk closed this Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants