Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show events that ended in past X hours (configurable) #122

Closed
rosenbergj opened this issue Jul 9, 2014 · 8 comments
Closed

show events that ended in past X hours (configurable) #122

rosenbergj opened this issue Jul 9, 2014 · 8 comments
Milestone

Comments

@rosenbergj
Copy link

I generally want to be able to see recently-ended events, but in this widget, they disappear as soon as the ending time is reached. I'd like to be able to configure the widget such that events don't disappear until X hours after they've ended. (Another widget lets you show events until midnight of the day they take place, which would also work for me; my events tend not to end immediately at midnight.)

@mpost
Copy link
Collaborator

mpost commented Jul 9, 2014

Thanks for your feedback. Other people also mentioned to be able to see the
entries longer. Should be a good addition.
Am 09.07.2014 18:49 schrieb "rosenbergj" [email protected]:

I generally want to be able to see recently-ended events, but in this
widget, they disappear as soon as the ending time is reached. I'd like to
be able to configure the widget such that events don't disappear until X
hours after they've ended. (Another widget lets you show events until
midnight of the day they take place, which would also work for me; my
events tend not to end immediately at midnight.)


Reply to this email directly or view it on GitHub
#122.

@yvolk
Copy link
Collaborator

yvolk commented Aug 5, 2014

A small addition: the list of events should be positioned at the current event (just like it is now!), allowing to scroll up to see past events.

@allanlaal
Copy link

past events could also be greyed out or be more opaque

@yvolk
Copy link
Collaborator

yvolk commented Apr 10, 2015

@allanlaal We recently added "Past events background color" option (to be released yet)

@yvolk
Copy link
Collaborator

yvolk commented Apr 10, 2015

@rosenbergj @mpost @allanlaal For consistency and simplicity I think we better have a list of predefined values. What exactly values may be needed?

So the name of the new option, located in "Event filters - Past events" will be: "Events that ended recently"
I would start from these values:

  1. "(this option is turned off)" - just like for another option: "Show past events with color"
  2. "1 hour ago"
  3. "2 hours ago"
  4. "4 hours ago"
  5. "Today"
  6. "One day ago"
    ...
    ?

@yvolk yvolk modified the milestone: 1.9 Apr 18, 2015
yvolk added a commit that referenced this issue Apr 18, 2015
@yvolk
Copy link
Collaborator

yvolk commented Apr 18, 2015

Implemented. Now "Event Filters" preferences screen looks like this:
scr-event-filters

@yvolk yvolk closed this as completed Apr 18, 2015
@mpost
Copy link
Collaborator

mpost commented Apr 18, 2015

I like this feature. One suggestion regarding the wording. I would remove the part ". Or turn this option off".

yvolk added a commit that referenced this issue Apr 18, 2015
@lexa1
Copy link

lexa1 commented Nov 21, 2015

please extend the option to show past events with "one week ago"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants