Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare watchmaker 0.16.4 release #947

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Prepare watchmaker 0.16.4 release #947

merged 1 commit into from
Aug 23, 2019

Conversation

eemperor
Copy link
Member

No description provided.

@eemperor eemperor requested a review from a team August 20, 2019 13:37
YakDriver
YakDriver previously approved these changes Aug 20, 2019
View reviewed changes
lorengordon
lorengordon previously approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member

@lorengordon lorengordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@eemperor
Copy link
Member Author

go codebuild go

@YakDriver
Copy link
Contributor

I restarted the codebuild job. It might just be a transient error.

@eemperor
Copy link
Member Author

Okay. Was thinking the same.

@eemperor
Copy link
Member Author

go codebuild go

6 similar comments
@YakDriver
Copy link
Contributor

go codebuild go

@eemperor
Copy link
Member Author

go codebuild go

@eemperor
Copy link
Member Author

go codebuild go

@eemperor
Copy link
Member Author

go codebuild go

@eemperor
Copy link
Member Author

go codebuild go

@eemperor
Copy link
Member Author

go codebuild go

@eemperor eemperor dismissed stale reviews from lorengordon and YakDriver via ed08b1f August 21, 2019 14:39
@eemperor
Copy link
Member Author

go codebuild go

2 similar comments
@YakDriver
Copy link
Contributor

go codebuild go

@YakDriver
Copy link
Contributor

go codebuild go

@eemperor
Copy link
Member Author

go codebuild go

1 similar comment
@eemperor
Copy link
Member Author

go codebuild go

lorengordon
lorengordon approved these changes Aug 23, 2019
View reviewed changes
Copy link
Member

@lorengordon lorengordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are green, change looks good to me

@eemperor eemperor merged commit 21f9cd7 into plus3it:develop Aug 23, 2019
@eemperor eemperor deleted the 0.16.4 branch August 23, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorengordon lorengordon lorengordon approved these changes

@YakDriver YakDriver YakDriver left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eemperor @YakDriver @lorengordon