Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output Watchmaker Version #330

Merged
merged 1 commit into from
Jun 26, 2017
Merged

Output Watchmaker Version #330

merged 1 commit into from
Jun 26, 2017

Conversation

KevinPlus3
Copy link
Contributor

Adding debug line to output Watchmaker version being run.

Addresses issue #329

lorengordon
lorengordon requested changes Jun 26, 2017
View reviewed changes
Copy link
Member

@lorengordon lorengordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the .cache file

@lorengordon
Copy link
Member

Probably worth adding .cache to .gitignore...

@KevinPlus3
Copy link
Contributor Author

Removed .cache directory. Not sure if I put the lines in the right section as I was playing around with testing at that point.

lorengordon
lorengordon requested changes Jun 26, 2017
View reviewed changes
.gitignore Outdated
@@ -80,9 +80,12 @@ src/*.log
tests/*.log

# Unit test / coverage reports
.cache/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just .cache will do it

.gitignore Outdated
.coverage
.tox
.coverage.*
__pycache__/
*/__pycache__/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is git attempting to include these __pycache__ directories now? I haven't seen that yet...

@codecov
Copy link

codecov bot commented Jun 26, 2017

Codecov Report

Merging #330 into develop will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #330      +/-   ##
===========================================
- Coverage    18.35%   18.33%   -0.03%     
===========================================
  Files           13       13              
  Lines          828      829       +1     
  Branches        94       94              
===========================================
  Hits           152      152              
- Misses         676      677       +1
Impacted Files Coverage Δ
src/watchmaker/__init__.py 16.66% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08124a5...5f457b2. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 26, 2017 •
edited
Loading

Codecov Report

Merging #330 into develop will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #330      +/-   ##
===========================================
- Coverage    18.35%   18.33%   -0.03%     
===========================================
  Files           13       13              
  Lines          828      829       +1     
  Branches        94       94              
===========================================
  Hits           152      152              
- Misses         676      677       +1
Impacted Files Coverage Δ
src/watchmaker/__init__.py 16.66% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08124a5...99581ee. Read the comment docs.

@KevinPlus3 KevinPlus3 force-pushed the output_version branch 3 times, most recently from 8e37ebb to ab8bf2c Compare June 26, 2017 19:02
lorengordon
lorengordon approved these changes Jun 26, 2017
View reviewed changes
Copy link
Member

@lorengordon lorengordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@KevinPlus3 KevinPlus3 merged commit ee9b493 into develop Jun 26, 2017
@KevinPlus3 KevinPlus3 deleted the output_version branch June 26, 2017 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorengordon lorengordon lorengordon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinPlus3 @lorengordon