Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issues with open. #323

Merged
merged 1 commit into from
Jun 7, 2017
Merged

Fixing issues with open. #323

merged 1 commit into from
Jun 7, 2017

Conversation

KevinPlus3
Copy link
Contributor

py2's open uses name as key for parameter while py3 uses file. Both expect path to be in first position, so a potential easy fix to just remove the key name=.

Fixes issue #322

…e'. An easy fix to to just remove key value and let open pick up on position.
@KevinPlus3 KevinPlus3 added the bug label Jun 7, 2017
@KevinPlus3 KevinPlus3 self-assigned this Jun 7, 2017
@codecov
Copy link

codecov bot commented Jun 7, 2017

Codecov Report

Merging #323 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #323   +/-   ##
========================================
  Coverage    18.35%   18.35%           
========================================
  Files           13       13           
  Lines          828      828           
  Branches        94       94           
========================================
  Hits           152      152           
  Misses         676      676
Impacted Files Coverage Δ
src/watchmaker/workers/yum.py 22.05% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d7dd84...1e9eeed. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 7, 2017

Codecov Report

Merging #323 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #323   +/-   ##
========================================
  Coverage    18.35%   18.35%           
========================================
  Files           13       13           
  Lines          828      828           
  Branches        94       94           
========================================
  Hits           152      152           
  Misses         676      676
Impacted Files Coverage Δ
src/watchmaker/workers/yum.py 22.05% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d7dd84...1e9eeed. Read the comment docs.

@lorengordon
Copy link
Member

:shipit:

@KevinPlus3 KevinPlus3 merged commit d06ab10 into develop Jun 7, 2017
@KevinPlus3 KevinPlus3 deleted the fix_open_issue branch June 7, 2017 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants