Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EL8 Findings README To Speak To Recently-Reported Findings #3030

Merged
merged 3 commits into from
Jul 19, 2023
Merged

Update EL8 Findings README To Speak To Recently-Reported Findings #3030

merged 3 commits into from
Jul 19, 2023

Conversation

ferricoxide
Copy link
Member

@ferricoxide ferricoxide commented Jun 30, 2023 •
edited
Loading

@ferricoxide ferricoxide requested a review from a team June 30, 2023 16:03
lorengordon
lorengordon reviewed Jun 30, 2023
View reviewed changes
Copy link
Member

@lorengordon lorengordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has two commits, instead of just the one?

@ferricoxide
Copy link
Member Author

ferricoxide commented Jun 30, 2023 •
edited
Loading

Has two commits, instead of just the one?

I'd branched off a branch since I didn't know how long the earlier approval was likely to take (and didn't want to have to deal with a merge-conflict).

If you've got a better suggestion for lining these up in a way that minimizes having to resolve merge conflicts, I'm all ears.
Should I redo the branch (and the ones coming after it) as a single-commit cherry-pick or similar?

@ferricoxide ferricoxide requested a review from lorengordon June 30, 2023 16:45
@ferricoxide ferricoxide changed the title Update EL8 Findings README to speak to V-230285 (RHEL-08-010471) [WIP] Update EL8 Findings README To Speak To Recently-Reported Findings Jun 30, 2023
@ferricoxide ferricoxide changed the title [WIP] Update EL8 Findings README To Speak To Recently-Reported Findings Update EL8 Findings README To Speak To Recently-Reported Findings Jun 30, 2023
lorengordon
lorengordon previously approved these changes Jun 30, 2023
View reviewed changes
@ferricoxide ferricoxide dismissed lorengordon’s stale review June 30, 2023 18:46

The merge-base changed after approval.

@ferricoxide ferricoxide requested a review from lorengordon June 30, 2023 18:49
lorengordon
lorengordon previously approved these changes Jul 10, 2023
View reviewed changes
@ferricoxide ferricoxide dismissed lorengordon’s stale review July 10, 2023 14:36

The merge-base changed after approval.

@ferricoxide ferricoxide requested a review from lorengordon July 13, 2023 13:42
@ferricoxide ferricoxide enabled auto-merge July 19, 2023 10:15
lorengordon
lorengordon reviewed Jul 19, 2023
View reviewed changes
@ferricoxide @lorengordon
Update docs/findings/el8.md
47cb601 
ypto

Co-authored-by: Loren Gordon <[email protected]>
@ferricoxide ferricoxide requested a review from lorengordon July 19, 2023 13:28
@ferricoxide ferricoxide merged commit b2deb5c into plus3it:main Jul 19, 2023
@ferricoxide ferricoxide deleted the Issue_3025 branch July 19, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorengordon lorengordon lorengordon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferricoxide @lorengordon