Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manages salt service during watchmaker install #237

Merged
merged 2 commits into from
Apr 5, 2017
Merged

Manages salt service during watchmaker install #237

merged 2 commits into from
Apr 5, 2017

Conversation

lorengordon
Copy link
Member

  • The salt-minion service is stopped before managing formulas
  • If the service is stopped (or not-yet-installed) before installing salt, the service remains stopped after watchmaker completes
  • If the service is running prior to the install (someone has intentionally started the service, and re-run watchmaker), then it remains running after watchmaker completes

Fixes #234
Fixes #72

@lorengordon lorengordon requested a review from KevinPlus3 April 4, 2017 19:31
@codecov
Copy link

codecov bot commented Apr 4, 2017

Codecov Report

Merging #237 into develop will decrease coverage by 0.66%.
The diff coverage is 14.28%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #237      +/-   ##
===========================================
- Coverage    19.12%   18.45%   -0.67%     
===========================================
  Files           14       14              
  Lines          774      818      +44     
  Branches        79       89      +10     
===========================================
+ Hits           148      151       +3     
- Misses         625      666      +41     
  Partials         1        1
Impacted Files Coverage Δ
src/watchmaker/workers/salt.py 14% <12.5%> (-0.53%) ⬇️
src/watchmaker/managers/base.py 18.3% <17.64%> (-1.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a32f1a1...da50475. Read the comment docs.

* The salt-minion service is stopped before managing formulas
* If the service is stopped (or not-yet-installed) before installing salt,
  the service remains stopped after watchmaker completes
* If the service is running prior to the install (someone has intentionally
  started the service, and re-run watchmaker), then it remains running
  after watchmaker completes

Fixes #234
Fixes #72
@lorengordon lorengordon merged commit 256664f into plus3it:develop Apr 5, 2017
@lorengordon lorengordon deleted the issue-234 branch April 5, 2017 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants