Skip to content

Copy structure-change from Core Plugwise#123

Merged
bouwew merged 6 commits intomasterfrom
core-split-copy
Oct 9, 2020
Merged

Copy structure-change from Core Plugwise#123
bouwew merged 6 commits intomasterfrom
core-split-copy

Conversation

@bouwew
Copy link
Copy Markdown
Contributor

@bouwew bouwew commented Oct 8, 2020

No description provided.

@bouwew bouwew requested a review from CoMPaTech October 8, 2020 18:28
"""Set up Plugwise components from a config entry."""
if entry.data.get(CONF_HOST):
return await async_setup_entry_gw(hass, entry)
# PLACEHOLDER USB entry setup
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True if we don't want to include #117 just yet (which was the goal, right)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's the idea, first, implement the structure-change from Core. Next step, implement #117.

"title": "Plugwise type",
"description": "Product:",
"data": {
"flow_type": "Connection type"
Copy link
Copy Markdown
Member

@CoMPaTech CoMPaTech Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bit might be where the 'flow_action' or thing from #117 came from, but it didn't reproduce for me in Core. Probably because we now just use it as a skip-through, but we should doublecheck this.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested with this code present, adding an Adam, both via discovery and manual adding, works as it did before the change.

Copy link
Copy Markdown
Member

@CoMPaTech CoMPaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bouwew bouwew merged commit 2873103 into master Oct 9, 2020
@bouwew bouwew deleted the core-split-copy branch October 21, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants