Skip to content

Convert pickle to jsonpickle for testdata in json#105

Merged
CoMPaTech merged 2 commits intomasterfrom
pickle2json
Sep 7, 2020
Merged

Convert pickle to jsonpickle for testdata in json#105
CoMPaTech merged 2 commits intomasterfrom
pickle2json

Conversation

@CoMPaTech
Copy link
Copy Markdown
Member

No description provided.

@CoMPaTech CoMPaTech requested a review from bouwew September 7, 2020 14:23
@CoMPaTech CoMPaTech added the enhancement New feature or request label Sep 7, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 7, 2020

Codecov Report

Merging #105 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #105   +/-   ##
=======================================
  Coverage   93.48%   93.48%           
=======================================
  Files           4        4           
  Lines        1396     1396           
=======================================
  Hits         1305     1305           
  Misses         91       91           
Impacted Files Coverage Δ
tests/test_Smile.py 97.26% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11424e7...92d0294. Read the comment docs.

@CoMPaTech
Copy link
Copy Markdown
Member Author

Lets wait for feedback on home-assistant/core#36371 before merging

@CoMPaTech CoMPaTech changed the title Convert pickle to picklejson for testdata Convert pickle to jsonpickle for testdata in json Sep 7, 2020
Copy link
Copy Markdown
Contributor

@bouwew bouwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good I think.

@CoMPaTech
Copy link
Copy Markdown
Member Author

Seeing upstream commands, lets switch - testdata generation only so no version bump required

@CoMPaTech CoMPaTech merged commit e457dc7 into master Sep 7, 2020
@CoMPaTech CoMPaTech deleted the pickle2json branch September 7, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants