enhance status display #2508
Merged
enhance status display #2508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btry
changed the title
btry
commented
Dec 21, 2021
| > div { | ||
| margin-bottom: 10px; | ||
| } | ||
| } |
There was a problem hiding this comment.
conflicts with cards : main area and cards on the right (my last forms) overlap
btry
force-pushed
the
bugfix/status_enhancements
branch
from
5a4223c to
98606a2
Compare
btry
commented
Dec 21, 2021
| @@ -823,38 +811,35 @@ a.plugin_formcreator_formTile_title { | |||
| } | |||
|
|
|||
| #plugin_formcreator_lastForms { | |||
| .plugin_formcreator_card { | |||
There was a problem hiding this comment.
specifying .plugin_formcreator_card is useless.
btry
commented
Dec 21, 2021
| echo '<li data-itemtype="PluginFormcreatorFormanswer" data-id="' . $formAnswer['id'] . '">'; | ||
| echo '<i class="'.$status.'"></i><a href="formanswer.form.php?id='.$formAnswer['id'].'">'.$formAnswer['name'].'</a>'; | ||
| echo '<span class="plugin_formcreator_date">'.Html::convDateTime($formAnswer['request_date']).'</span>'; | ||
| echo '</li>'; |
There was a problem hiding this comment.
deindent the lines : 1 level; show status with Font Awesome
btry
commented
Dec 21, 2021
| @@ -1082,21 +1085,24 @@ protected function showMyLastForms() : void { | |||
| echo '<div class="card-body text-center text-muted" >'.__('No form waiting for validation', 'formcreator').'</div>'; | |||
| } else { | |||
| echo '<div class="card-body">'; | |||
| echo '<ul>'; | |||
| echo '<ul class="list-group">'; | |||
There was a problem hiding this comment.
class was missing; see the 1st card in showMyLastForms() (a few dozens line above)
orthagh
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Common ITILObject statuses instead of icons (.png) provided by the plugin