Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required condition ignored #829

Closed
andreseliseo opened this issue Nov 14, 2017 · 12 comments · Fixed by #857
Closed

Required condition ignored #829

andreseliseo opened this issue Nov 14, 2017 · 12 comments · Fixed by #857
Assignees
Labels
Milestone

Comments

@andreseliseo
Copy link

Hi.
GLPI = 9.1.2
Forms = 2.5.2

When creating a question of:
Type: Select
Required: Yes
Show empty: Yes
Default values:
Values: List of my values
Description: My description
Hidden Unless: Some condition

User of the form can avoid to select some value of List of my values. He just left the Select field as "-----" and the required condition gets violated.

@andreseliseo andreseliseo changed the title Requiered conditioin ignored Required conditioin ignored Nov 14, 2017
@andreseliseo andreseliseo changed the title Required conditioin ignored Required condition ignored Nov 14, 2017
@btry
Copy link
Collaborator

btry commented Nov 15, 2017

Hi

do you have an opportinuty to check if the bug still occurs with the develop branch of the plugin (requires GLPI 9.2)

@andreseliseo
Copy link
Author

Hi. Thanks for the quick answer. We are currently generating a lab environment for testing this. We will post the result later.

@andreseliseo
Copy link
Author

Hi. Me again. The lab environment was created with success. GLPI was updated to v9.2 (be aware of php requiremets for thoose who try this!) and Forms was updated to the actual branch. The issue is still present at this versions. Will preserve this lab for further testing.

@btry
Copy link
Collaborator

btry commented Nov 16, 2017

Hi

Yes, please keep this lab. Once I investigated enough, I'll ask you for further information or to test a fix.

@andreseliseo
Copy link
Author

Hi. Did you have any opportunity to investigate this?

@btry
Copy link
Collaborator

btry commented Nov 27, 2017

No: i'm working full time on an other project the whole week. Please be patient.

@andreseliseo
Copy link
Author

Hi btry! Did you have any oportunity to go through this issue?

@btry
Copy link
Collaborator

btry commented Dec 13, 2017

Hi

only a gap to prepare a form to try to reproduce.

@sebelk
Copy link

sebelk commented Dec 18, 2017

Hi @btry I have the same problem that @andreseliseo , your fix will be very welcome, otherwise it's a pain to enforce a support policy.

Thanks in advance

@btry
Copy link
Collaborator

btry commented Dec 18, 2017

Hi

Please test the above patch and feedback

@btry btry self-assigned this Dec 18, 2017
@btry btry added the bug label Dec 18, 2017
@btry btry added this to the 2.6.1 milestone Dec 18, 2017
btry added a commit to btry/formcreator that referenced this issue Dec 19, 2017
@sebelk
Copy link

sebelk commented Dec 20, 2017

Thanks @btry ! It works

One caveat:

When it results in error, in order to get it working again, the page must be refreshed, otherwise menu options does not load options that depend on other items

HTH
SB

@btry
Copy link
Collaborator

btry commented Dec 21, 2017

Hi

Yes I noticed the same behavior, but this is an other bug, and it should happen no matter this one occurs or not.

btry added a commit to btry/formcreator that referenced this issue Jan 2, 2018
@btry btry closed this as completed in a820e55 Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants