Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to add a second criteria to the "display field" section in a question #1597

Closed
jnfohr opened this issue Jan 2, 2020 · 2 comments
Closed

Unable to add a second criteria to the "display field" section in a question #1597

jnfohr opened this issue Jan 2, 2020 · 2 comments
Assignees
@btry
Labels
bug
Milestone
2.9.1

Comments

@jnfohr
Copy link

jnfohr commented Jan 2, 2020

Hi,

Since the update to v2.9.0 I cannot add a secondary criteria to the "display field" (affichage du champ)section in a question.

The server returns a 400 error, it seems some fields are missing in the ajax request.

When I hit the '+' the request is:
GET /plugins/formcreator/ajax/condition.php?items_id=X

whereas when I insert a first criteria I get:
GET /plugins/formcreator/ajax/condition.php?itemtype=PluginFormcreatorQuestion&items_id=X&plugin_formcreator_sections_id=Y
btry added a commit to btry/formcreator that referenced this issue Jan 6, 2020
@btry
fix(condition): inability to add a rows to conditions
11e1080 
fix: pluginsGLPI#1597

Signed-off-by: Thierry Bugier <[email protected]>
@btry btry self-assigned this Jan 6, 2020
@btry btry added the bug label Jan 6, 2020
@btry btry added this to the 2.9.1 milestone Jan 6, 2020
@btry
Copy link
Collaborator

btry commented Jan 6, 2020

Hi

Can you try the above patch and feedback ?

@jnfohr
Copy link
Author

jnfohr commented Jan 6, 2020

Hi

Thanks, it's fine now, I can add a second condition.

Regards,

Jean-Noel

btry added a commit that referenced this issue Jan 6, 2020
@btry
fix(condition): inability to add a rows to conditions (#1598)
68ed7a1 
fix: #1597

Signed-off-by: Thierry Bugier <[email protected]>
@btry btry closed this as completed in 40129a6 Jan 6, 2020
btry added a commit that referenced this issue Jan 7, 2020
@btry
fix(condition): inability to add a rows to conditions (#1598)
bb1f2e4 
fix: #1597

Signed-off-by: Thierry Bugier <[email protected]>
btry added a commit that referenced this issue Jan 5, 2021
@btry
fix(condition): inability to add a rows to conditions
b4e0e87 
fix: #1597

Signed-off-by: Thierry Bugier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@btry btry

Labels
bug
Projects
None yet
Milestone
2.9.1
Development

No branches or pull requests
2 participants
@btry @jnfohr