Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support translations in old WordPress versions #91

Merged
merged 2 commits into from
Dec 30, 2020

Conversation

patrickrobrecht
Copy link
Member

  • Add load_plugin_textdomain for support of WordPress versions before 4.5
  • Declare compatibility with WordPress 4.1+

@codecov-io
Copy link

codecov-io commented Dec 30, 2020

Codecov Report

Merging #91 (cd8297c) into develop (85fe666) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop      #91      +/-   ##
=============================================
+ Coverage      40.29%   40.40%   +0.10%     
  Complexity       147      147              
=============================================
  Files              5        5              
  Lines            546      547       +1     
=============================================
+ Hits             220      221       +1     
  Misses           326      326              
Impacted Files Coverage Δ Complexity Δ
inc/class-antivirus.php 22.18% <100.00%> (+0.25%) 83.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85fe666...cd8297c. Read the comment docs.

@patrickrobrecht patrickrobrecht removed the request for review from stklcode December 30, 2020 16:27
@stklcode
Copy link
Contributor

  • Declare compatibility with WordPress 4.1+

As discussed on Slack, I've successfully tested Antivirus with WP 4.1 (official Docker image). In the meantime I also tested the plugin against a WP 3.8 installation without any issues. Testing requires a custom image, old MySQL version, etc. while 4.1 is quite handy.

So I'm fine with 4.1 for the sake of maintainability.

@patrickrobrecht patrickrobrecht merged commit 9764043 into develop Dec 30, 2020
@patrickrobrecht patrickrobrecht deleted the fix/old-wp-translations branch December 30, 2020 16:46
@patrickrobrecht patrickrobrecht added this to the 1.4.1 milestone Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants