fix theme file collection for duplicate names #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of reported regressions in the WP support forums: https://wordpress.org/support/topic/virus-alert-since-1-4-0/
WP_Theme::get_files()
returns an associative array with the relative file path as key and the absolute path as value. For child themes with files matching the parent's relative paths, these got overwritten byarray_merge()
. We only process the absolute path, so now we stripthe values and use numeric indices which are not squashed.
Example:
I've added a unit test for the
Antivirus_CheckInternals
class which does not yet verify any content processing, but it covers the file collection.