Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README and some translation strings #85

Merged
merged 3 commits into from
Dec 29, 2020
Merged

Conversation

patrickrobrecht
Copy link
Member

  1. Simplify the description in the README (including the changes from Fix declaration of WP compatiblity of AntiVirus 1.4.0 #84 merged into stable)
  2. Remove coderisk link from main plugin file
  3. Fix some translation strings which contain spelling mistakes or are inconsistent
  4. Remove FAQ section in the README and the link to the FAQ on the settings page (everything should be in the documentation now, the only question should be answered in the normal text now)

(Change 2 has been pushed to the 1.4.0 tag on SVN manually to trigger the import of the files after merging #84.)

Copy link
Contributor

@stklcode stklcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Dec 29, 2020

Codecov Report

Merging #85 (0f5f72a) into develop (2191d79) will increase coverage by 0.25%.
The diff coverage is 44.44%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop      #85      +/-   ##
=============================================
+ Coverage      26.25%   26.51%   +0.25%     
  Complexity       147      147              
=============================================
  Files              5        5              
  Lines            518      513       -5     
=============================================
  Hits             136      136              
+ Misses           382      377       -5     
Impacted Files Coverage Δ Complexity Δ
antivirus.php 0.00% <ø> (ø) 0.00 <0.00> (ø)
inc/class-antivirus.php 13.22% <0.00%> (+0.20%) 83.00 <0.00> (ø)
inc/class-antivirus-safebrowsing.php 91.30% <75.00%> (ø) 9.00 <0.00> (ø)
inc/class-antivirus-checksumverifier.php 89.83% <100.00%> (ø) 17.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2191d79...0f5f72a. Read the comment docs.

@patrickrobrecht patrickrobrecht merged commit 9530419 into develop Dec 29, 2020
@patrickrobrecht patrickrobrecht deleted the fix/cleanup branch December 29, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants