Deprecate pseudo-constructor and add init() method #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constructor only does static intiialization. The instance() method indicates some kind of singleton pattern, but actually only triggers the constructor without returning anything. Deprecate both in favor of a semantically more precise init() method.
Codecov Report
@@ Coverage Diff @@
## develop #79 +/- ##
=============================================
- Coverage 26.35% 26.25% -0.11%
- Complexity 146 147 +1
=============================================
Files 5 5
Lines 516 518 +2
=============================================
Hits 136 136
- Misses 380 382 +2
Continue to review full report at Codecov.
|
patrickrobrecht
changed the title
patrickrobrecht
approved these changes
Dec 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor only does static initialization. The
instance()method indicates some kind of singleton pattern, but actually only triggers the constructor without returning anything.Deprecate both in favor of a semantically more precise
init()method.