separate scan modules for daily execution #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up to now, the theme template check was mandatory for cron execution. It is now possible to enable only Safe Browsing or checksum verification for daily execution.
bueltge
reviewed
Apr 29, 2020
The method now takes an options array as input parameter to work on. This makes the method single source of truth for the cronjob status.
bueltge
approved these changes
Apr 29, 2020
|
Thank you, @stklcode❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to now, the theme template check was mandatory for cron execution.
It is now possible to enable only Safe Browsing or checksum verification for daily execution.
The JS has been modified to disable only the relevant inputs:
Before changing the JS, I've updates the code style and comments. Sorry for mixing this up, but I didn't want to write "old style" first or wait for another PR to be merged first.
Two further points I didn't address:
cronjob_enableis no longer what is used to be, as it just enabled the theme integrity check (yet backwards compatible without any additional update mechanism)