Integrate Checksum Verifier #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module compares checksums of WP core files against sums provided by the official API. The check is now embedded in the daily cron routine.
stklcode
force-pushed
the
feature/checksum-verifier
branch
from
5080bf8 to
1eb8b5b
Compare
This was referenced Jul 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR targets #5.
The check routine from Checksum Verifier is ported into a module and adds the check to the cron job.
To do so, I've moved the plugin's main class into a separate file and extracted all checks into subclasses, namely
AntiVirus_CheckInternals(theme checks)AntiVirus_SafeBrowsing(Google Safe Browsing check)AntiVirus_ChecksumVerifier(the ported verifier code)I know there's a lof of code moved...
SafeBrowsing changes in #55 cannot be merged automatically, so manual rework is required if this is merged.