script: mark file as OK only if all issues have been dismissed (#135) #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stklcode
force-pushed
the
fix/135-multiple-dismiss
branch
from
e74dc07 to
bf2a801
Compare
When multiple issues are present in a single file, clicking on "dismiss" should only hide the corresponding line and the file should only be marked as "OK" and turned green, if there are no more issues present. Refactor the response handler and only remove the parent element to resolve this issue.
stklcode
force-pushed
the
fix/135-multiple-dismiss
branch
from
bf2a801 to
7388743
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #135
When multiple issues are present in a single file, clicking on "dismiss" should only hide the corresponding line and the file should only be marked as "OK" and turned green, if there are no more issues present.
Refactor the response handler and only remove the parent element to resolve this issue.