Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

point Safe Browsing link on settings page to site-specific URL #106

Merged
merged 2 commits into from
May 13, 2021

Conversation

stklcode
Copy link
Contributor

@stklcode stklcode commented Apr 10, 2021

We already generate such link in the warning mail, so why not show it on the settings page, too.

mentioned in #104

@stklcode stklcode added this to the 1.4.3 milestone Apr 10, 2021
Copy link
Member

@Zodiac1978 Zodiac1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as expected.

The only idea I have is to add target="_blank" to the link and rel="noopener noreferrer" but I don't have a strong opinion on that.

@stklcode
Copy link
Contributor Author

Me neither, but we do open all other links (donation, documentation, support) in a new window, and thus it seems legit to do the same here.

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2021

Codecov Report

Merging #106 (dae30c2) into develop (b9c9afd) will decrease coverage by 0.43%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #106      +/-   ##
=============================================
- Coverage      39.43%   39.00%   -0.44%     
  Complexity       143      143              
=============================================
  Files              5        5              
  Lines            535      541       +6     
=============================================
  Hits             211      211              
- Misses           324      330       +6     
Impacted Files Coverage Δ Complexity Δ
antivirus.php 0.00% <ø> (ø) 0.00 <0.00> (ø)
inc/class-antivirus.php 21.76% <0.00%> (-0.42%) 83.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9c9afd...dae30c2. Read the comment docs.

@stklcode stklcode merged commit fde1266 into develop May 13, 2021
@stklcode stklcode deleted the feature/transparencyreport-link branch May 13, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants