Fix potential crash when deleting files from recently opened

plugdata-team · Dec 11, 2024 · 79cfce0 · 79cfce0
1 parent b53eb6f
commit 79cfce0
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/Source/Components/WelcomePanel.h b/Source/Components/WelcomePanel.h
@@ -820,20 +820,24 @@ class WelcomePanel : public Component
         }
 
         if (recentlyOpenedTree.isValid()) {
-            // Place favourited patches at the top
-            for (int i = 0; i < recentlyOpenedTree.getNumChildren(); i++) {
-
+            for (int i = recentlyOpenedTree.getNumChildren() - 1; i >= 0 ; i--) {
                 auto subTree = recentlyOpenedTree.getChild(i);
                 auto patchFile = File(subTree.getProperty("Path").toString());
-
                 if(!File(patchFile).existsAsFile())
                 {
                     if(!subTree.hasProperty("Removable"))
                     {
-                        recentlyOpenedTree.removeChild(subTree, nullptr);
+                        recentlyOpenedTree.removeChild(i, nullptr);
+
                     }
-                    continue;
                 }
+            }
+
+            // Place favourited patches at the top
+            for (int i = 0; i < recentlyOpenedTree.getNumChildren(); i++) {
+
+                auto subTree = recentlyOpenedTree.getChild(i);
+                auto patchFile = File(subTree.getProperty("Path").toString());
 
                 auto patchThumbnailBase = File(patchFile.getParentDirectory().getFullPathName() + "\\" + patchFile.getFileNameWithoutExtension() + "_thumb");