Skip to content
This repository was archived by the owner on Jul 4, 2022. It is now read-only.

Upgrade babe to the latest#124

Merged
cowboy-bebug merged 13 commits intodevelopfrom
upgrade/babe
Sep 1, 2020
Merged

Upgrade babe to the latest#124
cowboy-bebug merged 13 commits intodevelopfrom
upgrade/babe

Conversation

@cowboy-bebug
Copy link
Contributor

@cowboy-bebug cowboy-bebug commented Aug 19, 2020 •
edited
Loading

Here is the range of commits looked at:

Notable commits:

Commits not brought in:

Ignored weight-related commits:

Concern:

  • sp_core::traits::SpawnNamed not brought in
  • BasicQueue::new spawner param not brought in
  • frame_system::offchain::SendTransactionTypes not brought in (can't send equivocation report yet)

@cowboy-bebug cowboy-bebug force-pushed the upgrade/babe branch 13 times, most recently from b359d40 to ca73631 Compare August 24, 2020 06:31
@cowboy-bebug cowboy-bebug marked this pull request as ready for review August 31, 2020 00:27
@cowboy-bebug
Offchain Phragmén BREAKING. (#4517)
18dab6f 
commit: d123842
@cowboy-bebug
Add cherry-picks
f125d3c 
Make all `PerThing` types implement all trait methods on the type (#5422)
871e128

Build for only one target for docs.rs (#5427)
31352af
@cowboy-bebug
support: add lateness trait (#5519)
ca7d343 
0c7f8b2
@cowboy-bebug
Revise docs on randomness (#5497)
be1bba6 
3ac409b
@cowboy-bebug
Relax substrate licensing scheme (#5947)
194020e 
commit: dbf2163
@cowboy-bebug
Add notes about safe uses of twox (#6082)
14a0232 
commit: 73ff938
@cowboy-bebug
Correct BABE randomness by calculating InOut bytes directly in pallet…
89ef7d7 
… (#5876)

commit: 2b67057
[ci skip]
@cowboy-bebug
Add changes for #5876 to compile & run tests
7c85c02
@cowboy-bebug
babe: report equivocations (#6362)
adf0e3b 
commit: 18334ee
[ci skip]
@cowboy-bebug
Add changes for #6362 to compile & run tests
a9ad1f3
@cowboy-bebug
Remove warnings, add a TODO
593b4d6
@cowboy-bebug
Bump spec version
de945f2
jordy25519
jordy25519 approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@jordy25519 jordy25519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great on the whole.

  • definitely need to fix the equivocation transaction submission
  • both 5776 and 6008 look useful and would bring us closer to upstream. could be easily added in a follow up PR.

@cowboy-bebug cowboy-bebug merged commit 4bf79f4 into develop Sep 1, 2020
@cowboy-bebug cowboy-bebug deleted the upgrade/babe branch September 1, 2020 07:30
@jordy25519 jordy25519 mentioned this pull request Sep 25, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jordy25519 jordy25519 jordy25519 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cowboy-bebug @jordy25519

Comments