Open
Conversation
|
why this request did not merged? |
|
@antoni-g I tried running this project with your changes, I am able to launch it locally but unable to create any mapping. Upon clicking the save button, the app freezes and I can't see any request being made in the Network tab (no console errors as well). There is one error in the project Can you please help to check once? Let me know if you need any further details from my end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completing development for basic functionality, extending with features that were not available in the base repo
Goal was to allow the use of the UI to add/save/edit mappings.
Still room for improvement, but as is this fork is currently being used in my org for the intended purpose deployed to a cloud instance