Skip to content

Conversation

@alexcjohnson
Copy link
Collaborator

  • Generalizes the translation scripts @VeraZab made so we can reuse them in batch (didn't work for findTranslationKeys due to the different babel versions... but the other two are shared)
  • Localizes a few more things that were missed earlier

@alexcjohnson
Copy link
Collaborator Author

@VeraZab can you give this a quick review, then help me publish it so I can use it in https://github.com/plotly/plotly.js-batch-reporter/pull/24 ?

@alexcjohnson alexcjohnson requested a review from VeraZab January 17, 2018 15:43
@VeraZab
Copy link
Contributor

VeraZab commented Jan 17, 2018

yeah, was looking at it, well, looks good, so you'd like a new patch release?

@alexcjohnson
Copy link
Collaborator Author

alexcjohnson commented Jan 17, 2018

so you'd like a new patch release?

yes please 🙏

@alexcjohnson alexcjohnson merged commit 82d5c92 into master Jan 17, 2018
@alexcjohnson alexcjohnson deleted the share-i18n branch January 17, 2018 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants