Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#132]: Proposed Fix - "Plot show Method Not Working on Windows 10" #133

Merged
merged 2 commits into from
Jul 9, 2023

Conversation

M-NK-Y
Copy link
Contributor

@M-NK-Y M-NK-Y commented Jan 21, 2023

Changes show_with_default_app for target_os = "windows" to make use of spawn in place of output when attempting to open the temporary HTML file using the user's default browser. Additionally provides arguments within a shared object delegating command formatting to std::process:Command, which going forwards I think will be a safe bet to ensure path correctness.

@M-NK-Y M-NK-Y marked this pull request as draft January 21, 2023 03:51
@M-NK-Y M-NK-Y marked this pull request as ready for review January 21, 2023 03:54
@M-NK-Y
Copy link
Contributor Author

M-NK-Y commented Jan 21, 2023

As an aside, hopefully this isn't too late to mention in light of #129 but hopefully this proves to be a more robust solution going forwards by having the path formatting performed within the same args method.

@mfreeborn
Copy link
Contributor

Thanks for looking in to this.

Are you also able to change the latest changelog entry from:

Thanks to [@juanespj](https://github.com/juanespj) for the PR.

to

Thanks to [@juanespj](https://github.com/juanespj) and [@M-NK-Y](https://github.com/M-NK-Y) for the PRs.

@M-NK-Y
Copy link
Contributor Author

M-NK-Y commented Feb 16, 2023

Done!

@khoitsma
Copy link

khoitsma commented Mar 17, 2023

Question:

  • Is the "plot.show() not working in Windows 10" problem fixed in 0.8.3 ? (I think not)
  • Or is it to be fixed in 0.8.4 ? (Hopefully)

In Windows 11, using 0.8.3, plot.show() is not working for me

Thanks.

@fsktom
Copy link
Contributor

fsktom commented Apr 1, 2023

Can confirm this works. The HTML page is opened properly on my Windows 11 machine with plot.show() 👍🏿

@mfreeborn mfreeborn merged commit ac975d2 into plotly:master Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants