Include scattermapbox in main bundle
#816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we distribute partial bundles (after #740), it time to include the
scattermapboxtrace type in the main plotly.js dist bundle.As a result, the main bundle is quite a bit bigger:
To note, this PR does not add any
scattermapboximage test on CircleCI. As described in #626, running the mapbox image test in batch blows up the CircleCI box. Via #656 the image tests can now be run in queue (i.e. with no concurrency) with some hope of making thescattermapboximage mocks testable on CircleCI, but running them in queue single–handedly adds 2 minutes to our testing time (see here). I decided to no go forward with this for now.In brief, running the
mapboximage tests locally will now be part of the pre-release checklist.cc @chriddyp