Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --strict option to custom bundle #6557

Merged
merged 6 commits into from
Apr 17, 2023

Conversation

CallumNZ
Copy link
Contributor

@CallumNZ CallumNZ commented Apr 8, 2023

Reference: #6496

Changes:

  • Add --strict option to custom bundle command so that strict traces can be used in a custom bundle.

tasks/partial_bundle.js Outdated Show resolved Hide resolved
@archmoj archmoj added the community community contribution label Apr 13, 2023
@archmoj
Copy link
Contributor

archmoj commented Apr 13, 2023

Please also add draftlogs/6557_add.md as described here.
Thank you!

CallumNZ added a commit to CallumNZ/plotly.js that referenced this pull request Apr 14, 2023
CallumNZ added a commit to CallumNZ/plotly.js that referenced this pull request Apr 14, 2023
@archmoj archmoj added the feature something new label Apr 14, 2023
draftlogs/6557_add.md Outdated Show resolved Hide resolved
tasks/partial_bundle.js Outdated Show resolved Hide resolved
tasks/partial_bundle.js Outdated Show resolved Hide resolved
@archmoj
Copy link
Contributor

archmoj commented Apr 14, 2023

Thanks for the improvements 🥇
Please commit my suggestions above and this should be ready to go.

@archmoj
Copy link
Contributor

archmoj commented Apr 17, 2023

💃

@archmoj archmoj merged commit 21d09a6 into plotly:master Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution feature something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants