Skip to content

Fix modeBarButtons issue #6177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 9, 2022
Merged

Fix modeBarButtons issue #6177

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c1b6ff2
Fix modeBarButtons issue.
nickmelnikov82 May 5, 2022
dfc146d
Fixed lodash usage.
nickmelnikov82 May 5, 2022
8c2ea1c
Added test and draftlog.
nickmelnikov82 May 5, 2022
77383de
Move deep copy inside fillCustomButton function.
nickmelnikov82 May 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/modebar/manage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ var isUnifiedHover = require('../fx/helpers').isUnifiedHover;
var createModeBar = require('./modebar');
var modeBarButtons = require('./buttons');
var DRAW_MODES = require('./constants').DRAW_MODES;
var cloneDeep = require('lodash').cloneDeep;
Copy link
Contributor

@archmoj archmoj May 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the PR.
Please note that lodash is a dev-dependency.
And for various reasons (e.g. size & potential security issues) we are not interested to include that in our bundles.
Alternatively you could use

var extendDeep = require('../../lib').extendDeep;

and then

var customButtons = extendDeep([], context.modeBarButtons);

Or perhaps even better would be to use extendFlat if possible?

Copy link
Member Author

@nickmelnikov82 nickmelnikov82 May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Using the extendFlat function is not possible because the object has a nested structure.


/**
* ModeBar wrapper around 'create' and 'update',
Expand Down Expand Up @@ -44,7 +45,7 @@ module.exports = function manageModeBar(gd) {
].join(' '));
}

var customButtons = context.modeBarButtons;
var customButtons = cloneDeep(context.modeBarButtons);
var buttonGroups;

if(Array.isArray(customButtons) && customButtons.length) {
Expand Down