Skip to content

Fixup parcoords constraintrange valType and validate parcoords mocks #5673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 17, 2021
Merged

Fixup parcoords constraintrange valType and validate parcoords mocks #5673

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
58b2f64
adjust parcoords constraintrange valType - validate parcoords mocks
archmoj May 20, 2021
a3274c6
reflect schema changes
archmoj Jul 7, 2021
2dfec94
Merge remote-tracking branch 'origin/master' into parcoords-constrain…
archmoj Jul 17, 2021
f0ff80d
draft log for PR 5673
archmoj Jul 17, 2021
1e0aa6e
Merge remote-tracking branch 'origin/master' into parcoords-constrain…
archmoj Jul 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/traces/parcoords/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ module.exports = {
freeLength: true,
dimensions: '1-2',
items: [
{valType: 'number', editType: 'plot'},
{valType: 'number', editType: 'plot'}
{valType: 'any', editType: 'plot'},
{valType: 'any', editType: 'plot'}
],
editType: 'plot',
description: [
Expand Down
6 changes: 0 additions & 6 deletions tasks/test_mock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,12 +162,6 @@ function notBlackListed(name) {
'gl2d_fonts',
'gl2d_layout_image',
'gl2d_marker_coloraxis',
'gl2d_parcoords_256_colors',
'gl2d_parcoords_constraints',
'gl2d_parcoords_out-of-range_selected-above-below',
'gl2d_parcoords_out-of-range_selected-all',
'gl2d_parcoords_out-of-range_selected-below',
'gl2d_parcoords_select_first_last_enum',
'gl2d_pointcloud-basic',
'gl2d_rgb_dont_accept_alpha_scattergl',
'gl2d_scatter-marker-line-colorscales',
Expand Down
6 changes: 2 additions & 4 deletions test/image/mocks/gl2d_parcoords_out-of-range_selected-all.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,8 @@
{
"label": "A",
"constraintrange": [
[
2.5,
10
]
2.5,
10
],
"values": [
1,
Expand Down
4 changes: 2 additions & 2 deletions test/plot-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37750,11 +37750,11 @@
"items": [
{
"editType": "plot",
"valType": "number"
"valType": "any"
},
{
"editType": "plot",
"valType": "number"
"valType": "any"
}
],
"valType": "info_array"
Expand Down