Skip to content

Fix hover on mobile and tablet devices for gl3d subplots #5239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 2, 2020
Merged

Fix hover on mobile and tablet devices for gl3d subplots #5239

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f351cda
update gl-plot3d version
jdpaterson Oct 29, 2020
61b599f
fix scroll while panning test
jdpaterson Oct 29, 2020
cb116d0
use eslint friendly syntax
jdpaterson Oct 29, 2020
f4d03e4
update values passed to assertEvent
jdpaterson Oct 29, 2020
95ca0d9
bump gl-plot3d to ^2.4.7
jdpaterson Nov 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
"gl-mat4": "^1.2.0",
"gl-mesh3d": "^2.3.1",
"gl-plot2d": "^1.4.5",
"gl-plot3d": "^2.4.6",
"gl-plot3d": "git://github.com/jdpaterson/gl-plot3d.git#8f96f0362366394a188b2f7451faf4b48da85433",
"gl-pointcloud2d": "^1.0.3",
"gl-scatter3d": "^1.2.3",
"gl-select-box": "^1.0.4",
Expand Down
12 changes: 6 additions & 6 deletions test/jasmine/tests/gl3d_plot_interact_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,15 +941,15 @@ describe('Test gl3d drag and wheel interactions', function() {
var sceneTarget;
var relayoutCallback = jasmine.createSpy('relayoutCallback');

function assertEvent(e) {
expect(e.defaultPrevented).toEqual(true);
function assertEvent(e, passive) {
expect(e.defaultPrevented).toEqual(!passive);
relayoutCallback();
}

gd.addEventListener('touchend', assertEvent);
gd.addEventListener('touchstart', assertEvent);
gd.addEventListener('touchmove', assertEvent);
gd.addEventListener('wheel', assertEvent);
gd.addEventListener('touchend', function(e) { assertEvent(e, true); });
gd.addEventListener('touchstart', function(e) { assertEvent(e, true); });
gd.addEventListener('touchmove', function(e) { assertEvent(e, true); });
gd.addEventListener('wheel', function(e) { assertEvent(e, true); });

Plotly.plot(gd, mock)
.then(function() {
Expand Down