Skip to content

Conversation

@archmoj
Copy link
Contributor

@archmoj archmoj commented Aug 10, 2020

Fixes #5057.

@plotly/plotly_js

@archmoj archmoj changed the title t small numbers as years when bar Fix small sizes of bar with base Aug 10, 2020
@archmoj archmoj added status: reviewable bug something broken labels Aug 10, 2020
var cd = gd.calcdata;
assertPointField(cd, 'b', [[0]]);
assertPointField(cd, 's', [[2000]]);
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't these tests need to explicitly specify date axis type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed in 3e439e0.

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 💃

@archmoj archmoj merged commit ad1e8ff into master Aug 11, 2020
@archmoj archmoj deleted the fix5057-tiny-base branch August 11, 2020 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug something broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Base attribute bug

2 participants