Skip to content

Add Touch Support to RangeSlider #1098 #5025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Add Touch Support to RangeSlider #1098 #5025

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/components/rangeslider/draw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,21 +236,24 @@ function setupDragElement(rangeSlider, gd, axisOpts, opts) {
var grabAreaMin = rangeSlider.select('rect.' + constants.grabAreaMinClassName).node();
var grabAreaMax = rangeSlider.select('rect.' + constants.grabAreaMaxClassName).node();

rangeSlider.on('mousedown', function() {
function mouseDownHandler() {
var event = d3.event;
var target = event.target;
var startX = event.clientX;
var startX = event.clientX || event.touches[0].clientX;
var offsetX = startX - rangeSlider.node().getBoundingClientRect().left;
var minVal = opts.d2p(axisOpts._rl[0]);
var maxVal = opts.d2p(axisOpts._rl[1]);

var dragCover = dragElement.coverSlip();

this.addEventListener('touchmove', mouseMove);
this.addEventListener('touchend', mouseUp);
dragCover.addEventListener('mousemove', mouseMove);
dragCover.addEventListener('mouseup', mouseUp);

function mouseMove(e) {
var delta = +e.clientX - startX;
var clientX = e.clientX || e.touches[0].clientX;
var delta = +clientX - startX;
var pixelMin, pixelMax, cursor;

switch(target) {
Expand Down Expand Up @@ -295,9 +298,14 @@ function setupDragElement(rangeSlider, gd, axisOpts, opts) {
function mouseUp() {
dragCover.removeEventListener('mousemove', mouseMove);
dragCover.removeEventListener('mouseup', mouseUp);
this.removeEventListener('touchmove', mouseMove);
this.removeEventListener('touchend', mouseUp);
Lib.removeElement(dragCover);
}
});
}

rangeSlider.on('mousedown', mouseDownHandler);
rangeSlider.on('touchstart', mouseDownHandler);
}

function setDataRange(rangeSlider, gd, axisOpts, opts) {
Expand Down