Skip to content

Fix divider placement on reversed axes #4939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 23, 2020
Merged

Fix divider placement on reversed axes #4939

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
466f43c
Fix divider placement on reversed axes
justin-sleep Jun 22, 2020
75d91fa
Add mock for reversed axis dividers
justin-sleep Jun 22, 2020
86c0b60
Rewrite divider check for reversed axis
justin-sleep Jun 22, 2020
1118cfd
Replace baseline with Docker-generated image
justin-sleep Jun 22, 2020
f64ab49
Add check for empty vals in getDividerVals
justin-sleep Jun 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/plots/cartesian/axes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2100,6 +2100,9 @@ function getDividerVals(ax, vals) {
var out = [];
var i, current;

var xvals = vals.map(a => a.x);
var reversed = (xvals[1] < xvals[0]);

// never used for labels;
// no need to worry about the other tickTextObj keys
var _push = function(d, bndIndex) {
Expand All @@ -2113,11 +2116,11 @@ function getDividerVals(ax, vals) {
for(i = 0; i < vals.length; i++) {
var d = vals[i];
if(d.text2 !== current) {
_push(d, 0);
_push(d, reversed ? 1 : 0);
}
current = d.text2;
}
_push(vals[i - 1], 1);
_push(vals[i - 1], reversed ? 0 : 1);
}

return out;
Expand Down