Specify window size for the karma chrome launcher (Fixes #444) #445
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #444 by specifying a certain window size for the Chrome launcher. The numbers are simply derived from observing the window size in the properly working case.
CI karma/jasmine testing isn't impacted because, while CI piggybacks on this baseline config file, it specifies a separate browser (currently, Firefox). @etpinard suggested we don't change CI starting options right now.
I haven't experienced any problems with the fact that the
browserwe use is named differently (we can't name itChromeas it's wired to mean plain vanilla Chrome and is being referenced as thebase.